fix(timeout): do not reset steer wheels to 0. on timeout #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
moriarty,
progtologist and
VanshGehlot
reinzor
force-pushed
the
fix/timeout-handling
branch
from
00d9b3f
to
8a9658e
Compare
Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.
reinzor
force-pushed
the
fix/timeout-handling
branch
from
8a9658e
to
d706812
Compare
christophfroehlich
requested changes
Sep 19, 2024
There was a problem hiding this comment.
This makes sense to me, thanks for the contribution.
Could you please have a look on the failing tests and change the assertions accordingly?
Please add also a short description in the release_notes.
Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
reinzor
force-pushed
the
fix/timeout-handling
branch
from
14b57a5
to
dcbf13a
Compare
Signed-off-by: Rein Appeldoorn <rein.appeldoorn@nobleo.nl>
reinzor
force-pushed
the
fix/timeout-handling
branch
from
dcbf13a
to
ca0cefc
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1289 +/- ##
==========================================
- Coverage 80.34% 80.31% -0.04%
==========================================
Files 105 105
Lines 9393 9358 -35
Branches 831 826 -5
==========================================
- Hits 7547 7516 -31
+ Misses 1570 1567 -3
+ Partials 276 275 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
approved these changes
Sep 26, 2024
christophfroehlich
requested changes
Sep 27, 2024
steering_controllers_library/test/test_steering_controllers_library.cpp
Outdated
Show resolved
Hide resolved
steering_controllers_library/test/test_steering_controllers_library.cpp
Outdated
Show resolved
Hide resolved
…brary.cpp Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…brary.cpp Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting the incoming twist command velocity to zero, we should only set the wheel commands to zero without altering the steering angles in order to avoid in-place steering of the wheels.